Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method. #2481

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove deprecated method. #2481

merged 1 commit into from
Apr 4, 2023

Conversation

TingluoHuang
Copy link
Member

lint: testing/random.go#L9SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: Programs that call Seed and then expect a specific sequence of results from the global random source (using functions such as Int) can be broken when a dependency changes how much it consumes from the global random source. To avoid such breakages, programs that need a specific result sequence should use NewRand(NewSource(seed)) to obtain a random generator that other packages cannot access.  (staticcheck)

https://github.com/actions/actions-runner-controller/actions/runs/4611217178

Copy link
Member

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been meaning to do that for a while now 😄 Thank you for taking care of it!

@TingluoHuang TingluoHuang merged commit 5675409 into master Apr 4, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/deprecate branch April 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants