Add description for "dockerRegistryMirror" key #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More detailed explanation added. It should help users to avoid issues with the docker container. In case a user accidentally specifies a registry without HTTP(S) protocol it could cause an issue: Runner container log: Cannot connect to the Docker daemon at tcp://localhost:2376. Is the docker daemon running? Docker container log: Status: invalid argument "private-registry.example.net" for "--registry-mirror" flag: invalid mirror: unsupported scheme "" in "private-registry.example.net" See 'dockerd --help'., Code: 125
kalined
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
mumoshu
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed explanation added. It should help users to avoid issues with the docker container.
In case a user accidentally specifies a registry without HTTP(S) protocol it could cause an issue:
Runner container log:
Docker container log: