Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend manager roles to accept ephemeralrunnerset/finalizers #2493

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Extend manager roles to accept ephemeralrunnerset/finalizers #2493

merged 1 commit into from
Apr 10, 2023

Conversation

nikola-jokic
Copy link
Member

@nikola-jokic nikola-jokic commented Apr 7, 2023 •
edited

Fixes #2485

@nikola-jokic nikola-jokic requested review from mumoshu, toast-gear and a team as code owners April 7, 2023 14:50
@nikola-jokic nikola-jokic merged commit b86af19 into master Apr 10, 2023
16 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/ephemeralrunnerset-finalizer-permission branch April 10, 2023 06:49
@Link- Link- added this to the gha-runner-scale-set-0.5.0 milestone Jul 28, 2023
@Link- Link- added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jul 28, 2023
@Link- Link- mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.5.0
Development

Successfully merging this pull request may close these issues.

gha-runner-scale-set-controller fails to launch ephemeral runners due to a missing finalizer's setup
3 participants
@nikola-jokic @TingluoHuang @Link-