Fix GET validation for lowercase http methods #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some requests send method in lowercase, but Go HTTP library constant MethodGet is in upper.
argokasper
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
Link-
added
needs triage
mumoshu
previously approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Hey @argokasper! This is absolutely a good catch... I was blindly thinking that go's HTTP server would automatically upper-case the method on composing a request object, but apparently not.
I've just approved the CI workflow run on this pull request so I'll be able to merge this once it passes.
Thank you for your patience and contribution!
mumoshu
reviewed
Apr 27, 2023
controllers/actions.summerwind.net/horizontal_runner_autoscaler_webhook.go
Outdated
Show resolved
Hide resolved
mumoshu
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some requests send method in lowercase (verified with curl and as a default for AWS ALB health check requests), but Go HTTP library constant MethodGet is in upper.