Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm chart to support actions metrics graceful termiantion #2498

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Update helm chart to support actions metrics graceful termiantion #2498

merged 4 commits into from
Apr 27, 2023

Conversation

Smirl
Copy link
Contributor

@Smirl Smirl commented Apr 10, 2023

Summary

@Smirl
Copy link
Contributor Author

Smirl commented Apr 10, 2023

FYI @mumoshu . Thanks for the review.

@Link- Link- added needs triage Requires review from the maintainers community Community contribution labels Apr 17, 2023
mumoshu
mumoshu reviewed Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Smirl! Thank you so much for your contribution. I managed to review this today and had only one comment. Would you mind checking it? Once it's addressed, this is good to be merged!

charts/actions-runner-controller/Chart.yaml Outdated Show resolved Hide resolved
@Smirl
Copy link
Contributor Author

Smirl commented Apr 21, 2023

Thanks @mumoshu. Committed your suggestion and rebased.

mumoshu
mumoshu approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for your contribution @Smirl!

@mumoshu mumoshu merged commit 942f773 into actions:master Apr 27, 2023
10 checks passed
mumoshu added a commit that referenced this pull request May 11, 2023
@mumoshu
Bump chart version to v0.23.3 for ARC v0.27.4
1c54d7b 
Sorry for the delayed release!

This chart version is mainly for upgrading ARC to v0.27.4, along with a few fixes to the chart itself (#2504, #2498)

Please also refer to https://github.com/actions/actions-runner-controller/releases/tag/v0.27.4 for more details about changes made in ARC v0.27.4.
@mumoshu mumoshu mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@nikola-jokic nikola-jokic Awaiting requested review from nikola-jokic nikola-jokic is a code owner

Assignees
No one assigned
Labels
community Community contribution needs triage Requires review from the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Smirl @mumoshu @Link-