Use build.Version to check if resource version is a mismatch #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear and
a team
as code owners
nikola-jokic
changed the title
Link-
reviewed
Apr 21, 2023
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller.go
Outdated
Show resolved
Hide resolved
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller.go
Outdated
Show resolved
Hide resolved
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller.go
Outdated
Show resolved
Hide resolved
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller_test.go
Outdated
Show resolved
Hide resolved
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller_test.go
Outdated
Show resolved
Hide resolved
Link-
reviewed
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller_test.go
Outdated
Show resolved
Hide resolved
nikola-jokic
commented
Apr 21, 2023
controllers/actions.github.com/autoscalingrunnerset_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Link-
reviewed
Apr 21, 2023
Link-
reviewed
Apr 21, 2023
Link-
requested changes
Apr 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ARC deployment is removed in case of upgrade before rest of the resources are being cleaned up, use build.Version to check the version of the ARC and try to remove resources not matching this binary version
Fixes https://github.com/github/c2c-actions-runtime/issues/2426