Revert docker.sock path to /var/run/docker.sock #2536
Merged
+118
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en building container-based actions
… docker.sock path
mumoshu
requested review from
toast-gear,
a team and
nikola-jokic
as code owners
7 tasks
mumoshu
force-pushed
the
fix-docker-sock-path
branch
from
a295a33
to
a627141
Compare
nikola-jokic
approved these changes
Apr 26, 2023
|
Thank you very much for your review @nikola-jokic! Merging. |
|
@mumoshu when v0.27.4 will be released ? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting ARC v0.27.2, we've changed the
docker.sockpath from/var/run/docker.sockto/var/run/docker/docker.sock. That resulted in breaking some container-based actions due to the hard-codeddocker.sockpath in various places.Even
actions/runnerseem to use/var/run/docker.sockfor building container-based actions and for service containers?Anyway, this fixes that by moving the sock file back to the previous location.
Once this gets merged, users stuck at ARC v0.27.1, previously upgraded to 0.27.2 or 0.27.3 and reverted back to v0.27.1 due to #2519, should be able to upgrade to the upcoming v0.27.4.
Resolves #2519
Resolves #2538