Use head_branch metric #2549
Merged
Use head_branch metric #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th-le
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
Link-
added
needs triage
|
@mumoshu could you help take a look |
mumoshu
reviewed
May 27, 2023
go.mod
Outdated
| @@ -60,6 +62,7 @@ require ( | |||
| github.com/golang/protobuf v1.5.2 // indirect | |||
| github.com/google/gnostic v0.5.7-v3refs // indirect | |||
| github.com/google/go-github/v45 v45.2.0 // indirect | |||
| github.com/google/go-github/v52 v52.0.0 | |||
There was a problem hiding this comment.
Thank you @th-le! TIL that this had to be bumped in order to accommodate google/go-github@9385ab0.
However, I'm still unsure why this had to be in this second block of require.
Shouldn't it have resulted in updating L13 of this file?!
mumoshu
reviewed
May 27, 2023
Comment on lines
+28
to
+29
| golang.org/x/net v0.9.0 | ||
| golang.org/x/oauth2 v0.7.0 |
There was a problem hiding this comment.
These two versions seem to align with go-github v52 👍
mumoshu
reviewed
May 27, 2023
go.mod
Outdated
| golang.org/x/sync v0.1.0 | ||
| gomodules.xyz/jsonpatch/v2 v2.2.0 | ||
| gopkg.in/yaml.v2 v2.4.0 | ||
| k8s.io/api v0.26.2 | ||
| k8s.io/apimachinery v0.26.2 | ||
| k8s.io/client-go v0.26.2 | ||
| sigs.k8s.io/controller-runtime v0.14.4 | ||
| sigs.k8s.io/controller-runtime v0.14.6 |
There was a problem hiding this comment.
Can we leave this controller-runtime upgrade to another pull request to make this pull request focused on the head_branch addition? @th-le
|
the changes look good. thank you so much @mumoshu |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #2176.
This PR uses the branch_name for metrics