Adapt role name to prevent namespace collision #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmjd
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
nikola-jokic
added
the
gha-runner-scale-set
Closed
7 tasks
|
Fixes #2668 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deployment is not working for a single namespace deployment of the
gha-runner-scale-set-controller.This is due to the
manager_single_namespace_controller_roleand themanager_single_namespace_watch_rolewould both result in the same role name: ({{ include "gha-runner-scale-set-controller.managerSingleNamespaceRoleName" . }}) - leading to the error:roles.rbac.authorization.k8s.io "xxx-gha-runner-scale-set-controller-manager-single-namespace-role" already existsThis fix does rename the
watcherrole. By this, a single namespace deployment should be possible.