add interval and timeout configuration for the actions-runner-controler serviceMonitors #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler service monitors
arielly-parussulo
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
eliasscosta
approved these changes
Jun 7, 2023
Link-
added
needs triage
mumoshu
reviewed
Jul 25, 2023
mumoshu
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution @arielly-parussulo!
Link-
pushed a commit
that referenced
this pull request
Jul 26, 2023
…er serviceMonitors (#2654) Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow the customization of the interval and the timeout of the ServiceMonitors scraping.
Why?
I work in a company that has lots of workflows running and the controller generates lots of metrics in the /metrics path. When prometheus try to scrap the content of /metrics, it starts to face timeouts.
The default values for this chart are the default values for the Prometheus rules.
How?
By adding two new fields to the serviceMonitor map: interval and timeout. When the serviceMonitor is enabled (true), the serviceMonitor will be generated with these two properties.