Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serviceMonitor labels in actionsMetrics #2682

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fix serviceMonitor labels in actionsMetrics #2682

merged 1 commit into from
Jul 1, 2023

Conversation

marcin-motyl
Copy link
Contributor

@marcin-motyl marcin-motyl commented Jun 18, 2023 •
edited

serviceMonitorLabels are defined under actionsMetrics, not actionsMetricsServer.

See: https://github.com/actions/actions-runner-controller/blob/master/charts/actions-runner-controller/values.yaml#L308

@Link- Link- added needs triage Requires review from the maintainers community Community contribution labels Jun 23, 2023
mumoshu
mumoshu approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot for fixing it @marcin-motyl ☺️

@mumoshu mumoshu merged commit 685f716 into actions:master Jul 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@nikola-jokic nikola-jokic Awaiting requested review from nikola-jokic nikola-jokic is a code owner

Assignees
No one assigned
Labels
community Community contribution needs triage Requires review from the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcin-motyl @mumoshu @Link-