Add configurable log format to values.yaml and propagate it to listener #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear and
a team
as code owners
Link-
reviewed
Jun 23, 2023
| @@ -79,6 +79,7 @@ flags: | |||
| ## Log level can be set here with one of the following values: "debug", "info", "warn", "error". | |||
| ## Defaults to "debug". | |||
| logLevel: "debug" | |||
| logFormat: "text" | |||
There was a problem hiding this comment.
Can we please add a comment with the accepted log formats?
Link-
requested changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Expose a
log-formatparameter through the helm charts that will allow end users to specify the log format for the autoscaling runner set controller manager and listener.This
log-formatwill not propagate to the runners because they have a distinct logging structure.