Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow more dockerd options #2701

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: allow more dockerd options #2701

merged 1 commit into from
Jul 25, 2023

Conversation

twildber
Copy link
Contributor

  • Added a description how to mount a configmap to configure multiple docker daemon options
  • Moved the directory structure creation for the rootless-docker runner to the image.
    That way it will not break permissions while mounting the configmap.

provides feature: #2700

@Link- Link- added needs triage Requires review from the maintainers community Community contribution labels Jul 3, 2023
mumoshu
mumoshu approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your patience and awesome contribution @twildber!

@mumoshu mumoshu merged commit dc58f6b into actions:master Jul 25, 2023
@twildber twildber deleted the feat-more-dockerd-options branch July 25, 2023 17:41
Link- pushed a commit that referenced this pull request Jul 26, 2023
@twildber
feat: allow more dockerd options (#2701)
77feb71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@nikola-jokic nikola-jokic Awaiting requested review from nikola-jokic nikola-jokic is a code owner

Assignees
No one assigned
Labels
community Community contribution needs triage Requires review from the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twildber @mumoshu @Link-