Clarify multiple metrics in docs #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hadn't seen any examples or documentation about how combining multiple HorizontalRunnerAutoscalers behaves in close proximity to the explanation of the metric types in the documentation, so I didn't know if it was even allowed. This commit moves the explanation from *Autoscaling to/from 0* to *Pull Driven Scaling*, where it clarifies usage closer to the metric definitions.
julietrb1
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
Link-
added
community
mumoshu
approved these changes
Aug 9, 2023
nikola-jokic
pushed a commit
that referenced
this pull request
Sep 1, 2023
Co-authored-by: Dylan Boyd <5061312+dylanjboyd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't seen any examples or documentation about how combining multiple HorizontalRunnerAutoscalers behaves in close proximity to the explanation of the metric types in the documentation, so I didn't know if it was even allowed.
This commit moves the explanation from Autoscaling to/from 0 to Pull Driven Scaling, where it clarifies usage closer to the metric definitions.