Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set build version on make-runscaleset #2713

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jul 1, 2023

This enables us to locally test various runner versions.

For example, you can now run VERSION=0.4.0 make run-scaleset to let the local runnerscaleset controller to manage runners deployed using the runner-scale-set chart v0.4.0.

This enables us to locally test various runner versions. For example, you can now run `VERSION=0.4.0 make run-scaleset` to let the local runnerscaleset controller to manage runners deployed using the runner-scale-set chart v0.4.0.
@mumoshu mumoshu requested review from toast-gear, a team and nikola-jokic as code owners July 1, 2023 04:56
Copy link
Member

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@Link-
Copy link
Collaborator

Link- commented Jul 3, 2023

🚢 it!

@Link- Link- added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jul 3, 2023
@nikola-jokic nikola-jokic added this to the 0.5.0 milestone Jul 3, 2023
@nikola-jokic nikola-jokic merged commit 2fee26d into master Jul 3, 2023
11 checks passed
@nikola-jokic nikola-jokic deleted the set-build-version-on-make-run branch July 3, 2023 09:52
@Link- Link- mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants