Fix panic: slice bounds out of range when runner spec contains volumeMounts.
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umeMounts`. As observed in actions#2719, if a `Runner` contains a `work` volume mount, this will cause a panic in `newPod()` where the code is assuming that the `work` volume mount will be present in the `pod` definition generated by `newRunnerPodWithContainerMode()`. However that isn't always the case, and if it's not present the `-1` returned by `workVolumeMountPresent` results in the `slice bounds out of range` exception. So instead, check the `bool` return value, and only attempt to remove the `work` volume mount if it's actually present. Also apply the same fix to the `volumes` logic. Fixes actions#2719 Signed-off-by: Gavin Williams <gavin.williams@machinemax.com>
fatmcgav
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
7 tasks
Link-
pushed a commit
that referenced
this pull request
Jul 26, 2023
…umeMounts`. (#2720) Signed-off-by: Gavin Williams <gavin.williams@machinemax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #2719, if a
Runnercontains aworkvolume mount, thiswill cause a panic in
newPod()where the code is assuming that theworkvolume mount will be present in thepoddefinition generated bynewRunnerPodWithContainerMode().However that isn't always the case, and if it's not present the
-1returned by
workVolumeMountPresentresults in theslice bounds out of rangeexception.So instead, check the
boolreturn value, and only attempt to removethe
workvolume mount if it's actually present.Also apply the same fix to the
volumeslogic.Fixes #2719
Signed-off-by: Gavin Williams gavin.williams@machinemax.com