fixed indent in a README example #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ephemeral` is in `.spec.template.spec` path not `.spec.template`. Took us some time to figure out after c&p from the README
prein
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
mrsensey
approved these changes
Jul 15, 2023
mumoshu
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Good catch!! Thanks a lot for your contribution @prein
Re tmp sharing, I'm not entirely sure.. You only need to mount it only when you want the tmp directory to persists between ephemeral runner pods.
If you don't need persitency, you can just omit the volume mount(as you might have already done).
Link-
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ephemeralis in.spec.template.specpath not.spec.template. Took us some time to figure out after c&p from the READMEApologies for not following the contributing guide, but this is such a minor change...
BTW, I should probably open an issue for that but sharing
/tmpin my setup leads topreventing the runner from starting. Why share
/tmpat all?