Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scaling back to 0 after min runners were set to number > 0 #2742

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix scaling back to 0 after min runners were set to number > 0 #2742

merged 2 commits into from
Aug 9, 2023

Conversation

nikola-jokic
Copy link
Member

Fixes #2734

@nikola-jokic nikola-jokic requested review from mumoshu, toast-gear and a team as code owners July 13, 2023 14:41
@Link-
Copy link
Collaborator

Link- commented Jul 26, 2023

Excellent! I bumped into this today and was going to create an issue for it. Glad to see it's getting resolved 🥳

@Link- Link- added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jul 26, 2023
@Link- Link- added this to the gha-runner-scale-set-0.5.0 milestone Jul 27, 2023
@Link- Link- mentioned this pull request Jul 28, 2023
Merged
johnsudol
johnsudol approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@johnsudol johnsudol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikola-jokic nikola-jokic merged commit 336e11a into master Aug 9, 2023
14 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/listenr-scale-to-0 branch August 9, 2023 08:32
nikola-jokic added a commit that referenced this pull request Sep 1, 2023
@nikola-jokic
Fix scaling back to 0 after min runners were set to number > 0 (#2742)
ef98503
@nikola-jokic nikola-jokic restored the nikola-jokic/listenr-scale-to-0 branch September 26, 2023 09:51
@nikola-jokic nikola-jokic deleted the nikola-jokic/listenr-scale-to-0 branch September 26, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsudol johnsudol johnsudol approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.5.0
3 participants
@nikola-jokic @Link- @johnsudol