Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs - Add missing formatting #2780

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Logs - Add missing formatting #2780

merged 2 commits into from
Aug 9, 2023

Conversation

luka5
Copy link
Contributor

@luka5 luka5 commented Jul 26, 2023

Follow up to #2320

Right now the logs look like:

INFO    -watch-namespace is %q. Only HorizontalRunnerAutoscalers in %q are watched, cached, and considered as scale targets.    {"my-namespace": "my-namespace"}

But I expect it to look like:

INFO    -watch-namespace is "my-namespace". Only HorizontalRunnerAutoscalers in "my-namespace" are watched, cached, and considered as scale targets.

@luka5 luka5 changed the title Add missing formatting Logs - Add missing formatting Jul 26, 2023
@Link- Link- added needs triage Requires review from the maintainers community Community contribution labels Jul 28, 2023
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution @luka5!

@mumoshu mumoshu merged commit 7827100 into actions:master Aug 9, 2023
14 checks passed
nikola-jokic pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution needs triage Requires review from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants