Revert chart name and use helper constant to trim the name base #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear and
a team
as code owners
Link-
previously approved these changes
Aug 21, 2023
Merged
Link-
approved these changes
Aug 21, 2023
|
This change doesn't allow for helm upgrade resulting in the below error. Trying to uninstall and install also returns the same error. It looks like there may have been a missed item in the reverting of the chart name as the error implies that it's still looking for gha-rs-controller in the manager_role_binding.yaml. Error: UPGRADE FAILED: execution error at (gha-runner-scale-set/templates/manager_role_binding.yaml:17:11): No gha-rs-controller deployment found using label (app.kubernetes.io/part-of=gha-rs-controller). Consider setting controllerServiceAccount.name in values.yaml to be explicit if you think the discovery is wrong.Any thoughts on where this is being set? I tried looking at the broader change to see if there may have been something missed, but can't spot it without diving much deeper. |
nikola-jokic
added a commit
that referenced
this pull request
Sep 1, 2023
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #2706 - this PR will revert back the helm chart renaming.