Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: set max and min runners during startup time #3032

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Metrics: set max and min runners during startup time #3032

merged 1 commit into from
Nov 7, 2023

Conversation

nikola-jokic
Copy link
Contributor

Fixes #3030

@nikola-jokic nikola-jokic changed the title Set max and min runners during startup time Metrics: set max and min runners during startup time Nov 1, 2023
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Nov 1, 2023
fhammerl
fhammerl approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhammerl fhammerl merged commit 1681523 into master Nov 7, 2023
15 checks passed
@fhammerl fhammerl deleted the nikola-jokic/fix-listener-max-min branch November 7, 2023 13:20
@nikola-jokic nikola-jokic mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerl fhammerl fhammerl approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.7.0
Development

Successfully merging this pull request may close these issues.

Lack of metrics (like listener max_runners)
2 participants
@nikola-jokic @fhammerl