Fix rate limit and runner not registered detection logic and action #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* errors.Is compares all members of a struct to return true which never happened * switched to type check instead of exact value check * notRegistered was using double negation in if statement which lead to unregistering runners after the registration timeout
jonico
deleted the
fix-rate-limit-and-runner-not-found-detection-and-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the changes introduced by feat: Prevent blocking on transient runner registration failure #297 - conditions to detect not found runners or rate limit exceptions have never been triggered because
errors.Iscompares all members of a struct to return true which never happenedswitched to type check instead of exact value check and use references instead of copying values
in changes introduced by feat: Prevent blocking on transient runner registration failure #297 runners have been deregistered all 10 minutes (de-registration timeout), no matter whether they have failed to register or not because the if statement checking notRegistered was using double negation in if statement which lead to deregistration in all cases
changed if statement to only deregister if actually needed and cleaned up error messages and detection logic in replicaset and runner controllers