Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics to include repository on job-based label #3310

Merged
merged 2 commits into from Mar 18, 2024

Conversation

nikola-jokic
Copy link
Member

@nikola-jokic nikola-jokic commented Feb 28, 2024

When creating labels used for the job-related metrics, apply repository name based on the job message, instead of githubConfigUrl.

Also, fix the comment in listener_test.

Partially addresses #3185

Co-authored-by: Samuel Rats <samuel.rats@teads.com>
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikola-jokic nikola-jokic merged commit 814947c into master Mar 18, 2024
15 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/metrics-repo branch March 18, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants