Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring dind image and service account #3394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow configuring dind image and service account #3394

wants to merge 4 commits into from
+11 −1

Conversation

shaul75
Copy link

@shaul75 shaul75 commented Mar 31, 2024 •
edited

The PR addresses 2 of our issues

  1. a service account with a specific annotation is needed to grant the runner pod IAM permissions in EKS. https://docs.aws.amazon.com/eks/latest/userguide/associate-service-account-role.html
  2. Changing the dind image to pull from another repository
    We have a base values.yaml with common options for all runner sets. this change allows to override just the dind image as a base value, without copy-pasting the entire block.

Related Discussion: #3256

@Hazmi35 Hazmi35 mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@nikola-jokic nikola-jokic Awaiting requested review from nikola-jokic nikola-jokic is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shaul75