Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom dind config and node tolerations for runner pod #3540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Custom dind config and node tolerations for runner pod #3540

wants to merge 1 commit into from
+39 −1

Conversation

th-le
Copy link
Contributor

@th-le th-le commented May 24, 2024

Changes

  • Add custom dind config to allow private registry images to be used in dind container
  • Allows dind container to use a custom network range to avoid conflicting IPs with IP ranges in cloud provider like AWS
  • Use node tolerations for runner pod to have more flexibility in scheduling the required pods

@th-le th-le changed the title Custom dind config and node tolerations for runner pob Custom dind config and node tolerations for runner pod May 24, 2024
kahirokunn added a commit to kahirokunn/actions-runner-controller that referenced this pull request Jun 5, 2024
@kahirokunn
Ensure resources are not managed by ArgoCD (actions#3540)
8ff50ee 
Remove the "argocd.argoproj.io/instance" label from resources created by the controller. This prevents ArgoCD from pruning and deleting these resources when syncing.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn added a commit to kahirokunn/actions-runner-controller that referenced this pull request Jun 13, 2024
@kahirokunn
Ensure resources are not managed by ArgoCD (actions#3540)
199cc53 
Remove the "argocd.argoproj.io/instance" label from resources created by the controller. This prevents ArgoCD from pruning and deleting these resources when syncing.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@nikola-jokic nikola-jokic Awaiting requested review from nikola-jokic nikola-jokic is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@th-le