Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PercentageRunnersBusy scaling not working #386

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Mar 11, 2021

PercentageRunnerBusy seems to have regressed since #355 due to that RunnerDeployment.Spec.Selector is empty by default and the HRA controller was using that empty selector to query runners, which somehow returned 0 runners. This fixes that by using the newly added automatic runner-deployment-name label for the default runner label and the selector, which avoids querying with empty selector.

Ref #377 (comment)

PercentageRunnerBusy seems to have regressed since #355 due to that RunnerDeployment.Spec.Selector is empty by default and the HRA controller was using that empty selector to query runners, which somehow returned 0 runners. This fixes that by using the newly added automatic `runner-deployment-name` label for the default runner label and the selector, which avoids querying with empty selector.

Ref #377 (comment)
@mumoshu mumoshu force-pushed the fix-percentage-runners-busy branch from 7463039 to e863513 Compare March 11, 2021 11:12
@mumoshu mumoshu merged commit 3d62e73 into master Mar 11, 2021
@mumoshu mumoshu deleted the fix-percentage-runners-busy branch March 11, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant