Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delay min/maxReplicas propagation from HRA to RD due to caching #406

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Do not delay min/maxReplicas propagation from HRA to RD due to caching #406

merged 1 commit into from
Mar 19, 2021

Commits on Mar 19, 2021

  1. Do not delay min/maxReplicas propagation from HRA to RD due to caching 

    As part of #282, I have introduced some caching mechanism to avoid excessive GitHub API calls due to the autoscaling calculation involving GitHub API calls is executed on each Webhook event.

Apparently, it was saving the wrong value in the cache- The value was one after applying `HRA.Spec.{Max,Min}Replicas` so manual changes to {Max,Min}Replicas doesn't affect RunnerDeployment.Spec.Replicas until the cache expires. This isn't what I had wanted.

This patch fixes that, by changing the value being cached to one before applying {Min,Max}Replicas.

Follow-up for #282
    @mumoshu
    mumoshu committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    92fdda9 View commit details
    Browse the repository at this point in the history