fix(#951): add exception for self-hosted label in webhook search #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception should be temporary, ideally the labels implicitely created (self-hosted, OS, architecture) should be searchable.
ghost
changed the title
ghost
marked this pull request as draft
ghost
changed the title
ghost
marked this pull request as ready for review
2 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mumoshu
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
It took a bit more time until I figure out how this aligns with all the other aspects of the system. After rereading your comments and lastly @fgalind1's suggestion and summary, I'm finally confident with this change.
LGTM. Thank you so much for your patience and contribution!
mumoshu
pushed a commit
that referenced
this pull request
Dec 21, 2021
KENNYSOFT
added a commit
to KENNYSOFT/actions-runner-controller
that referenced
this pull request
Jan 6, 2022
KENNYSOFT
added a commit
to KENNYSOFT/actions-runner-controller
that referenced
this pull request
Jan 6, 2022
mumoshu
pushed a commit
that referenced
this pull request
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #951
The webhook "workflowJob" pass the labels the job needs to the controller, who in turns search for them in its RunnerDeployment / RunnerSet. The current implementation ignore the search for
self-hostedif this is the only label, however if multiple labels are found theself-hostedlabel must be declared explicitely or the RD / RS will not be selected for the autoscaling.This PR fixes the behavior by ignoring this label, and add documentation on this webhook for the other labels that will still require an explicit declaration (OS and architecture).
The exception should be temporary, ideally the labels implicitely created (self-hosted, OS, architecture) should be searchable alongside the explicitly declared labels.
code tested, work with
["self-hosted"]and["self-hosted","anotherLabel"]