dockerEnabled for Stricter Clusters like OpenShift #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a draft while I test this out.
Motivation
I would like it so my users can make
Runners
without Docker access since on OpenShift that requires aSecurityContextConstraints
. Other K8s clusters might require aPodSecurityPolicy
instead FWIW.Desired Experience
If users attempt to make a
Runner
withdockerEnabled: true
and they don't have an SCC for theServiceAccount
they specified usingserviceAccountName
it will fail to create a pod and this is reflected in the Runner's status (this already occurs today without thedockerEnabled
option).If
dockerEnabled: false
is set, the user will then be able to haveRunners
createPods
without having to make an SCC/PSP because the Docker sidecar and volumes are omitted.