Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update volumes and volumes mounts indent #966

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

gscho
Copy link
Contributor

@gscho gscho commented Nov 26, 2021

I was getting YAML parse error on actions-runner-controller/templates/deployment.yaml and when I investigated it seems the indent by values were off by 2.

These are the values I was testing with:

additionalVolumeMounts:
- mountPath: /etc/ssl/certs
  name: ghe-cert
  readOnly: true
additionalVolumes:
- name: ghe-cert
  secret:
    secretName: ghecert

Signed-off-by: Gregory Schofield gscho@github.com

Signed-off-by: Gregory Schofield <gscho@github.com>
@gscho gscho changed the title Update volumes and volumes mounts indent fix: update volumes and volumes mounts indent Nov 26, 2021
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this has been introduced via #952. Thanks for fixing it @gscho!

@mumoshu mumoshu merged commit 85ddd0d into actions:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants