Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to release workflow and architecture options #71

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

h2floh
Copy link
Contributor

@h2floh h2floh commented Mar 21, 2023

  • Generally remove 386 arch
  • Add macos arm64
  • Switch from deprecated --rm-dist to --clean flag for goreleaser
  • Bump actions/setup-go to v4

Signed-off-by: Florian Wagner <h2floh@github.com>
@h2floh h2floh requested a review from a team as a code owner March 21, 2023 00:32
- <<: *build_defaults
id: linux
goos: [linux]
goarch: [386, amd64, arm64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think customers can still use 32 machine. I see we support cli as well 32 bundle.
CleanShot 2023-03-21 at 10 17 50@2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it from the release process until we found the reason and fix for the current int overflow, then we can reenable it. Currently we are publishing binaries which won't work.

@h2floh h2floh merged commit 416384c into main Mar 21, 2023
@jrarmstro jrarmstro mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants