Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow projects outside github.com #338

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Allow projects outside github.com #338

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
399442f
change regex to support non-github.com URLs
saravanan30erd Mar 23, 2023
07c29ba
remove TODO comment and update error message
saravanan30erd Mar 30, 2023
2a9da7b
Update src/add-to-project.ts
iansan5653 Mar 30, 2023
90818bf
fix test - throws an error when url isn't a valid project url
saravanan30erd Mar 30, 2023
38a0adc
fix dist check
saravanan30erd Mar 30, 2023
5d4ef34
Merge branch 'main' of https://github.com/actions/add-to-project into…
iansan5653 Mar 31, 2023
74235d0
Invert test that rejected non-github.com URLs
iansan5653 Mar 31, 2023
039f00e
Merge pull request #1 from iansan5653/fix-url-match
saravanan30erd Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/add-to-project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as github from '@actions/github'
// TODO: Ensure this (and the Octokit client) works for non-github.com URLs, as well.
iansan5653 marked this conversation as resolved.
Show resolved Hide resolved
// https://github.com/orgs|users/<ownerName>/projects/<projectNumber>
const urlParse =
/^(?:https:\/\/)?github\.com\/(?<ownerType>orgs|users)\/(?<ownerName>[^/]+)\/projects\/(?<projectNumber>\d+)/
/\/(?<ownerType>orgs|users)\/(?<ownerName>[^/]+)\/projects\/(?<projectNumber>\d+)/
iansan5653 marked this conversation as resolved.
Show resolved Hide resolved

interface ProjectNodeIDResponse {
organization?: {
Expand Down Expand Up @@ -80,7 +80,7 @@ export async function addToProject(): Promise<void> {

if (!urlMatch) {
throw new Error(
`Invalid project URL: ${projectUrl}. Project URL should match the format https://github.com/<orgs-or-users>/<ownerName>/projects/<projectNumber>`,
`Invalid project URL: ${projectUrl}. Project URL should match the format <Github server FQDN>/<orgs-or-users>/<ownerName>/projects/<projectNumber>`,
iansan5653 marked this conversation as resolved.
Show resolved Hide resolved
)
}

Expand Down