Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init attest action #4

Merged
merged 5 commits into from
Feb 23, 2024
Merged

init attest action #4

merged 5 commits into from
Feb 23, 2024

Conversation

ejahnGithub
Copy link
Contributor

@ejahnGithub ejahnGithub commented Feb 22, 2024

Move the attest code from https://github.com/github/attestation-action

TODOs:

  • packages/attest will be replaced after we have npm package for packages/attest
  • add unit test

Copy link
Collaborator

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of organizational changes:

  • Let's NOT check-in the packages/attest/dist directory
  • Move all of the files from src/helper to just the src directory
  • Ditch any code that we don't need as part of this action (e.g. sbom.ts)

Copy link
Collaborator

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ejahnGithub ejahnGithub merged commit 247ce30 into main Feb 23, 2024
15 of 17 checks passed
@ejahnGithub ejahnGithub deleted the eugene/initAttest branch February 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants