add list support for subjectPath input #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
force-pushed
the
bdehamer/subject-array
branch
from
ace2c5b
to
d1ed0c4
Compare
Signed-off-by: Brian DeHamer <bdehamer@github.com>
Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/subject-array
branch
from
d1ed0c4
to
44a50b9
Compare
| /* eslint-disable-next-line github/no-then */ | ||
| const files = await glob.create(subPath).then(async g => g.glob()) | ||
|
|
||
| for (const file of files) { |
There was a problem hiding this comment.
This is not new for this pr, but I'm thinking if we should have a limit of the number of subjects/attestations we store. I could think a low number like 64 ought to be enough. I would be a better experience to stop in the action and warn before the rate limit stops this:
Create too much content on GitHub in a short amount of time. In general, no more than 80 content-generating requests per minute and no more than 500 content-generating requests per hour are allowed
kommendorkapten
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: actions/attest-build-provenance#57
Allows the
subjectPathinput to accept a list of paths. Any of the list elements may itself be a glob representing multiple files.The path list can be commas-separated:
or newline separated:
or any combination of the two: