Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support pathname except ssh #1305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: support pathname except ssh #1305

wants to merge 3 commits into from

Conversation

ischanx
Copy link

@ischanx ischanx commented Apr 27, 2023

In some cases pathname is required, but SSH does not support pathname.

close #1242

@ischanx ischanx requested a review from a team as a code owner April 27, 2023 16:11
Copy link

@Makonike Makonike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@ZAlexanderV ZAlexanderV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Checked on instance - works.

@Makonike
Copy link

Any movement on this PR? Really waiting on this feature to complete a new system for work environment.

@ikuo
Copy link

ikuo commented Jun 23, 2023

Just FYI, I think we can temporally reference this update as follows:

  steps:
    - uses: ischanx/checkout@06c611454073903c9d44641d7e085b21115d3dcf

@frankli0324
Copy link

@TingluoHuang would you like to have a look on this?

@garymoon
Copy link

@TingluoHuang would you like to have a look on this?

@megamanics Could we tempt you pretty please? 🙏 💙

@sosyco
Copy link

sosyco commented Aug 26, 2023

Successfully tested on a gitea-instance behind a proxy and with subpath

@megamanics
Copy link
Contributor

@TingluoHuang would you like to have a look on this?

@megamanics Could we tempt you pretty please? 🙏 💙

please add some test cases to demonstrate its usage.

@frankli0324
Copy link

frankli0324 commented Oct 13, 2023

@ischanx would you please update the merge request or maybe you could grant me or @Reverier-Xu write permission on your fork and so maybe we could finish things up?

@joshmgross
Copy link
Member

👋 This is not something we currently plan to support - see #1242 (comment) for more info.

@frankli0324
Copy link

frankli0324 commented Oct 21, 2023

@joshmgross you don't need to plan to support, it's already there
please understand how open-source works, at least try to understand, will you?

@OdinVex
Copy link

OdinVex commented Oct 21, 2023

@joshmgross you don't need to plan to support, it's already there please understand how open-source works, at least try to understand, will you?

It's obvious what Micro$oft is trying to do with this. It'll just be up to Gitea, Forgejo, etc to fork actions and prevent actions from requesting GitHub by default and instead use Instance actions. At least that won't be difficult, just a base uri change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GITHUB_SERVER_URL does not preserve URI prefix