Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give test-ubuntu-git its own README #1620

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Give test-ubuntu-git its own README #1620

merged 5 commits into from
Feb 22, 2024

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented Feb 21, 2024

By default, test-ubuntu-git is inheriting the README.md of actions/checkout.

image

It should have a separate README. This PR achieves that.

@jww3 jww3 requested a review from a team as a code owner February 21, 2024 16:07
@jww3
Copy link
Contributor Author

jww3 commented Feb 22, 2024

Food for thought: should we emit a WARNING when a user runs the "rebuild package" workflow with the publish option from a branch other than main? (Probably should be a separate PR.)

I'll do this in a separate PR.

Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor suggestion

Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
@jww3 jww3 merged commit 2650dbd into main Feb 22, 2024
11 checks passed
@jww3 jww3 deleted the jww3-patch-1 branch February 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants