Warn on attempts to publish test-ubuntu-git from non-main branch. - #1623
Merged
Conversation
jww3
commented
Feb 22, 2024
Comment on lines
+46
to
+47
| if: ${{ inputs.publish && github.ref_name != 'main' }} | ||
| run: echo "::warning::test-ubuntu-git images can only be published from the actions/checkout 'main' branch. Workflow will continue with push/publish disabled." |
Contributor
Author
There was a problem hiding this comment.
see similar conditional logic in line 57
Link-
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we built the
test-ubuntu-gitimage generation workflow, we made the decision to only allow thetest-ubuntu-gitcontainer image to be published from themainbranch ofactions/checkout. (see #1617)This PR updates the workflow to explain (via a warning message) why an image push attempt from a non-
mainbranch didn't have the desired effect (for users that weren't paying close attention to the label of the checkbox which reads:"Publish to ghcr.io? (main branch only)").Note that
pushis an opt-in behavior of reusable workflowdocker/build-push-action.There's diagnostic value in the build attempt that precedes any would-be image push, so I chose not to fail the workflow outright, but rather to let the build proceed and simply skip the push.