Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFetchUrl: compose url with full service url #1664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vicamo
Copy link

@vicamo vicamo commented Mar 21, 2024

actions/checkout maybe used by Gitea, which allows installing the server instance in a subdirectory to the service root, therefore a full serviceUrl must be used.

actions/checkout maybe used by Gitea, which allows installing the
server instance in a subdirectory to the service root, therefore a full
serviceUrl must be used.

Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
@vicamo vicamo requested a review from a team as a code owner March 21, 2024 16:09
@joshmgross
Copy link
Member

See #1242 (comment) for our current stance on supporting uses of this action outside of GitHub Actions.

@vicamo
Copy link
Author

vicamo commented Mar 29, 2024

See #1242 (comment) for our current stance on supporting uses of this action outside of GitHub Actions.

Yes, but why is there an additional .origin access if the github.server_url should have already given the right url for further access? It's redundant, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants