Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert errors into Actions-compatible logging with annotations #138

Merged
merged 6 commits into from Mar 28, 2024

Conversation

JamesMGreene
Copy link
Contributor

... As a result, if generator_config_file is not specified, then errors within the setPagesConfig function will always be blamed on an incorrect file extension.

The behavior describes in that blurb is mostly due to the fact that we were incorrectly passing the Error object as the second parameter to core.error/core.warning/core.notice when those methods are actually expecting an AnnotationProperties object with error-like metadata.

This PR updates the messages being logged to include the error.message, as well as including the error stack frame information in the AnnotationProperties optional arugment.

@JamesMGreene JamesMGreene requested a review from a team as a code owner March 28, 2024 03:48
@JamesMGreene JamesMGreene merged commit 7781abd into main Mar 28, 2024
6 checks passed
@JamesMGreene JamesMGreene deleted the error-utils branch March 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants