Support custom permissions #3
Labels
feature
New feature or request
Comments
|
|
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Dec 19, 2023
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Dec 19, 2023
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Dec 19, 2023
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Dec 19, 2023
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Dec 20, 2023
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
added a commit
to product-os/flowzone
that referenced
this issue
Jan 2, 2024
This deprecates support for the token_scope input for custom actions which wasn't used anywhere anyway. It also deprecates support for the installation_id input as the installation will be derived from the repo owner. The old token action is still in use to enable auto-merge where custom token scopes were still required. This will be removed in the future when custom permissions are supported by the new action. See: tibdex/github-app-token#99 See: actions/create-github-app-token#3 Resolves: #790 Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
follow up to: 2d5eced
Our idea is to add separate
permission_*parameters for each permission supported by GitHub Apps:https://docs.github.com/en/rest/overview/permissions-required-for-github-apps
The
permission_*keys can be generated based off https://github.com/octokit/app-permissions. Each time a new version of@octokit/app-permissionsis released, theaction.ymlcould be updated, in order to keep permissions always up-to-date. TheREADME.mdshould be updated as well to make sure the documentation is up-to-date as well. Most permissions can be set toreadorwrite, some can also be set toadmin.Having separate permissions has the benefit of code intelligence and errors shown directly on GitHub when an unknown permission is set due to a typo.
The text was updated successfully, but these errors were encountered: