Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read configuration from external repositories #306

Merged
merged 27 commits into from
Nov 10, 2022
Merged

Conversation

cnagadya
Copy link
Contributor

@cnagadya cnagadya commented Oct 26, 2022

This PR adds support for reading configuration options from files external to the repo where the Action is being run. This enables users to have the config file in another repository, allowing organizations to centralise the configuration in a single file.

Closes #285.

src/config.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
__tests__/config.test.ts Outdated Show resolved Hide resolved
__tests__/config.test.ts Outdated Show resolved Hide resolved
@cnagadya cnagadya marked this pull request as ready for review November 8, 2022 11:19
@cnagadya cnagadya requested a review from a team as a code owner November 8, 2022 11:19
@febuiles
Copy link
Contributor

febuiles commented Nov 8, 2022

@courtneycl would you mind helping us review the copy for README.md? We could use a fresh set of eyes :)

@febuiles febuiles changed the title External repo config Read configuration from external repositories Nov 9, 2022
Copy link
Collaborator

@courtneycl courtneycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made just a couple suggestions. I do think we should revamp this and go with a table or something to make it easier to read; I'll take a whack at that in another PR after this one.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
febuiles and others added 4 commits November 10, 2022 07:59
Co-authored-by: Courtney Claessens <courtneycl@github.com>
Co-authored-by: Courtney Claessens <courtneycl@github.com>
Co-authored-by: Courtney Claessens <courtneycl@github.com>
@febuiles febuiles merged commit 4108a15 into main Nov 10, 2022
@febuiles
Copy link
Contributor

@courtneycl I made a few tweaks to the README, feel free to open a new PR to update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUESTION: Config file outside current repo
3 participants