-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Repository Improvements #155
Conversation
…t of the 'all' script
|
||
it('executes cleanly', done => { | ||
const ip = path.join(__dirname, '../index.js') | ||
cp.exec(`node ${ip}`, { env: process.env }, (err, stdout) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
it('execution fails if there are missing variables', done => { | ||
delete process.env.ACTIONS_RUNTIME_URL | ||
const ip = path.join(__dirname, '../index.js') | ||
cp.exec(`node ${ip}`, { env: process.env }, (err, stdout) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions! Lots of great nuggets within this PR. 💝 😍
I've taken the liberty of rolling back some of the changes that didn't feel especially relevant or desirable. ⏪
In the future, I would encourage a handful of smaller PRs instead of one large PR, as that typically results in less effort needed to get the favorable bits merged. 🙏🏻 🙇🏻
General Repository Improvements
This pull request does the following:
CODEOWNERS
fileCONTRIBUTING.md
file for new contributors__tests__
andsrc/
dir withfunctions
folder