Explicitly handle cancellation on errors #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannchaudet
commented
Aug 24, 2022
Comment on lines
+173
to
+174
| await this.cancel() | ||
| return |
There was a problem hiding this comment.
This is new and I think will not hurt.
yoannchaudet
commented
Aug 24, 2022
| @@ -109,7 +109,7 @@ class Deployment { | |||
| const statusUrl = | |||
| this.deploymentInfo != null | |||
| ? this.deploymentInfo['status_url'] | |||
| : `${this.githubApiUrl}/repos/${this.repositoryNwo}/pages/deployment/status/${process.env['GITHUB_SHA']}` | |||
| : `${this.githubApiUrl}/repos/${this.repositoryNwo}/pages/deployment/status/${this.buildVersion}` | |||
There was a problem hiding this comment.
We don't use other environment variable in this file so normalizing to what's in the context. Did the same for cancel below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deployment reaches the client side timeout, we don't cancel it. This PR addresses that.
This also explicit cancel a deployment after too many errors pulling the status (this may not work but I feel it's best to be safer here).