Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditions to print for list commands #43

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

t-dedah
Copy link
Contributor

@t-dedah t-dedah commented Nov 20, 2022

What are you trying to accomplish?

This PR will make sure we render non tabular information only if the output is terminal. This will help us to pipe the output from cli and use them efficiently. Most urgent use case for this is support the delete cache doc PR

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

@t-dedah t-dedah requested a review from a team as a code owner November 20, 2022 18:47
Copy link
Contributor

@kotewar kotewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@tanuj077 tanuj077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-dedah t-dedah merged commit 9adb9e8 into main Nov 21, 2022
@t-dedah t-dedah deleted the t-dedah/fix-term branch November 21, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants