Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set CGO_ENABLED with env directive #68

Merged
merged 2 commits into from
May 16, 2023
Merged

fix: Set CGO_ENABLED with env directive #68

merged 2 commits into from
May 16, 2023

Conversation

jidicula
Copy link
Contributor

What are you trying to accomplish?

  • env directive must be used for setting environment variables in Windows.
  • Modifies triggers for e2e tests to run on every PR to main.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

@jidicula jidicula requested a review from a team as a code owner May 16, 2023 16:17
kgrzebien
kgrzebien approved these changes May 16, 2023
View reviewed changes
Copy link

@kgrzebien kgrzebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jidicula jidicula merged commit a9d75d1 into main May 16, 2023
15 checks passed
@jidicula jidicula deleted the jidicula/fix-cgo-enabled-e2e branch May 16, 2023 17:18
@javs-perez javs-perez assigned javs-perez and unassigned javs-perez May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgrzebien kgrzebien kgrzebien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jidicula @kgrzebien @javs-perez