Added test cases for Delete #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/kotewar/error-handling-and-tests
…rs/kotewar/error-handling-and-tests
t-dedah
approved these changes
Jul 13, 2022
| @@ -44,30 +49,46 @@ func NewCmdDelete() *cobra.Command { | |||
| if !f.Confirm { | |||
| matchedCaches, err := getCacheListWithExactMatch(f, artifactCache) | |||
| if err != nil { | |||
| return err | |||
| var httpError api.HTTPError | |||
There was a problem hiding this comment.
This error handling is exactly same with list.go so abstract this out to a separate function
| f.Confirm = choice == "Delete" | ||
| fmt.Println() | ||
| } | ||
| if f.Confirm { | ||
| cachesDeleted, err := artifactCache.DeleteCaches(queryParams) | ||
| if err != nil { | ||
| return err | ||
| var httpError api.HTTPError |
There was a problem hiding this comment.
This can also be handled using the same error handling function proposed above.
|
Merging this now and expect another PR to resolve comments. This is being done to not overload this PR and also close the long running PR. |
| sizeWidth := SIZE_COLUMN_WIDTH // hard-coded size as the content is scoped | ||
| timeWidth := LAST_ACCESSED_AT_COLUMN_WIDTH // hard-coded size as the content is scoped | ||
| keyWidth := int(math.Floor(0.75 * (width - 15 - 20))) | ||
| refWidth := int(math.Floor(0.25 * (width - 15 - 20))) | ||
| keyWidth := int(math.Floor(0.65 * float64(width-15-20))) |
There was a problem hiding this comment.
Please use consts SIZE_COLUMN_WIDTH and LAST_ACCESSED_AT_COLUMN_WIDTH instead of hard-coded values. I missed it in my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes
delete.goPending items
confirmflag