Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the bundle check output #90

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

JamesMGreene
Copy link
Contributor

@JamesMGreene JamesMGreene commented Jun 21, 2023

Fixes #79

Towards:

Avoids the confusion if the warning message begins showing up:

Warning:  github-pages can't satisfy your Gemfile's dependencies.

I debated storing the output into a temporary file until we assess if the check failed but, for most cases, I think the output will be so small that it's not really worth the extra gymnastics. 馃し馃徎

@JamesMGreene JamesMGreene requested a review from a team as a code owner June 21, 2023 15:44
Copy link
Collaborator

@yoannchaudet yoannchaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair!

@JamesMGreene JamesMGreene merged commit 899cec3 into main Jun 21, 2023
10 checks passed
@JamesMGreene JamesMGreene deleted the show-bundle-check-output branch June 21, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the output of bundle check be un-hidden?
2 participants