Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work when uses is a ref #1

Closed
ianks opened this issue Apr 4, 2019 · 3 comments
Closed

Does not work when uses is a ref #1

ianks opened this issue Apr 4, 2019 · 3 comments

Comments

@ianks
Copy link

ianks commented Apr 4, 2019

For some reason, labeler does not work when uses is a ref to this repo, but if I build the container and ref that, all is well.

# ....
action "Apply Labels" {
  # Does not work...
  # uses  = "actions/labeller@v1.0.0"

  # Works
  uses  = "docker://my-own-docker-repo/issue-labeler:latest"
  needs = "On Sync"

  env = {
    LABEL_SPEC_FILE = ".github/label/spec.yml"
  }

  secrets = ["GITHUB_TOKEN"]
}
@xzilja
Copy link

xzilja commented Apr 30, 2019

Indeed, following fails

workflow "Label PR" {
  on = "pull_request"
  resolves = "Labeler"
}

action "Synchronize or Opened" {
  uses = "actions/bin/filter@master"
  args = "action 'opened|synchronize'"
}

action "Labeler" {
  uses = "actions/labeller@master"
  needs = "Synchronize or Opened"
  env = {
    LABEL_SPEC_FILE=".github/labeler.yml"
  }
  secrets = ["GITHUB_TOKEN"]
}

With error

STARTED Labeler 15:14:41Z

Already have image (with digest): gcr.io/github-actions-images/action-runner:latest

FAILED Labeler 15:14:52Z (11.208s)

@ktravers
Copy link

@ianks @iljadaderko there's a typo in the README instructions. Specifically, the uses line has a typo in the name of the library.

if you update to uses = "actions/labeler@master" ("labeler" with one "L" instead of 2), then the action will execute as expected.

I've just submitted a PR with the update: #2

@damccorm
Copy link
Contributor

damccorm commented Aug 23, 2019

Closing since this deals with issues in the previous syntax. If that seems wrong feel free to comment an I'll reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants