Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rerun build and update main branch dist/index.js #94

Closed
taehwanno opened this issue Sep 8, 2020 · 1 comment
Closed

Need to rerun build and update main branch dist/index.js #94

taehwanno opened this issue Sep 8, 2020 · 1 comment

Comments

@taehwanno
Copy link

taehwanno commented Sep 8, 2020

Problem

In #22, it was built based on @actions/core old version and merged into main. As a result, an error like #88 occurs.

Solution

We need to rerun build and update main branch dist/index.js with @actions/core v1.2.4

Additional work to prevent recurrence

It seems possible to add the steps below to prevent a recurrence.

  1. Add prebuild script (npm install) for installing the latest dependencies in each developer's local machine. (Fix #94 #95)
  2. Add branch protection rule to main branch (Enable "Require branches to be up to date before merging" in "Require status checks to pass before merging") -> maybe someone possible?
@taehwanno taehwanno mentioned this issue Sep 8, 2020
@dakale
Copy link
Contributor

dakale commented Sep 8, 2020

Should be fixed now, see #95

@dakale dakale closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants