There is no AGENT_TOOLSDIRECTORY on GitHub images

[mjpieters]

This change reflects what the Windows installer already does: https://github.com/mjpieters/python-versions/blob/c0e7ef2c3c5b8e3dce50c0caceaafb4a5266a36c/installers/win-setup-template.ps1#L82-L87

[mjpieters]

Incidentally: the setup-python README tells us to open issues here in the python-versions repository to request new Python releases:

• If there is a specific version of Python that is not available, you can open an issue in the python-versions repository.

Yet this repository doesn’t have the issues option enabled. Oversight perhaps?

[konradpabjan]

Hello @mjpieters

Apologies for the README discrepancies (I've updated it now). I forgot to update that section, when i removed some other references to creating issues in this repository.

The reason issues are closed in this repo is so that it is easier to maintain and triage. Python issues come in setup-python and virtual-environments so having a third repository to regularly check on would become difficult

[konradpabjan]

@maxim-lobanov, @MaksimZhukov could you take a look at this small code change?

[maxim-lobanov]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[maxim-lobanov]

Hello @mjpieters, your changes LGTM. We didn't do these changes initially because Hosted Ubuntu images have AGENT_TOOLSDIRECTORY as far as I know. But your fix is important to support self-hosted agents properly.

Currently, CI fails on your changes because of the way that we use to generate installer scripts. I have improved it in scope of #22 . Could you please pull latest master to your branch and I will rerun CI?

[mjpieters]

@MaksimZhukov I rebased and force-pushed, I suspect that now means you have to run the pipeline manually. GitHub doesn't think there is a need for any checks, at any rate.

[mjpieters]

Nope, I don't have permission to do this myself. :-)

[azure-pipelines]

Commenter does not have sufficient privileges for PR 21 in repo actions/python-versions

[maxim-lobanov]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[maxim-lobanov]

looks like azp run doesn't run build properly :(
I have run checks manually: https://github.visualstudio.com/virtual-environments/_build/results?buildId=67728&view=logs&j=a851cb31-2814-50bb-6af1-fa649763ba71&t=f0eef93c-9563-5abf-9747-41cd68506a2a

[mjpieters]

Looks like the manual build completed successfully.

[maxim-lobanov]

@mjpieters , merged. I will re-upload existing versions with this fix.

[maxim-lobanov]

All versions were regenerated and re-uploaded with this fix